bpo-45155 : Default arguments for int.to_bytes(length=1, byteorder=sys.byteorder) by warsaw · Pull Request #28265 · python/cpython

warsaw · 2021-09-09T22:28:12Z

In the PEP 467 discussion, I proposed being able to use

>>> (65).to_bytes()
b'A'

IOW, adding default arguments for the length and byteorder arguments to int.to_bytes()

It occurs to me that this is (1) useful on its own merits; (2) easy to do. So I've done it.

https://bugs.python.org/issue45155

rhettinger · 2021-09-09T22:32:56Z

This is a nice improvement. Thanks.

ericvsmith

This all looks reasonable to me. But .format() instead of f-strings? What?!

rhettinger · 2021-09-09T22:37:05Z

The main docs need to be updated as well: https://docs.python.org/3/library/stdtypes.html?highlight=to_bytes#int.to_bytes

warsaw · 2021-09-09T22:43:24Z

This all looks reasonable to me. But .format() instead of f-strings? What?!

Ha! I knew you'd say that 😆
I wanted to minimally edit the line so it would fit within my editor line length. That looked like some Python 2.6 code to me!

The main docs need to be updated as well: https://docs.python.org/3/library/stdtypes.html?highlight=to_bytes#int.to_bytes

Yep, thanks @rhettinger ... coming up!

rhettinger · 2021-09-09T22:45:13Z

Also consider updating the default byteorder for int.from_bytes. The to/from round trip should be as symmetrical as possible.

brandtbucher

Beat me to it! I agree that int.from_bytes deserves the same treatment, too.

I also saw one possible improvement:

encukou · 2021-09-10T07:41:39Z

Please, for the sake of reproducible science (and other cases), don't add platform-dependent defaults.

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

bedevere-bot · 2021-09-10T23:05:17Z

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

warsaw · 2021-09-10T23:12:50Z

I have made the requested changes; please review again.

bedevere-bot · 2021-09-10T23:12:52Z

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

brandtbucher

Looks good! Just one RST nit:

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

warsaw · 2021-09-15T04:51:02Z

"big" by default.

brandtbucher

I think you missed some!

bedevere-bot · 2021-09-15T16:34:03Z

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

…55.JRw9TG.rst Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

warsaw · 2021-09-15T16:43:25Z

Thanks for catching the ones I missed @brandtbucher

warsaw · 2021-09-15T16:44:04Z

I have made the requested changes; please review again.

bedevere-bot · 2021-09-15T16:44:08Z

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

brandtbucher

Sorry, I promise this is my last review!

Just realized that we can help AC give us a better __text_signature__ (for help, inspect, etc.). Other than that improvement, this looks good!

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

brandtbucher · 2021-09-15T21:42:11Z

(I think you need to re-run AC locally, too.)

bedevere-bot · 2021-09-16T02:55:27Z

@warsaw: Please replace # with GH- in the commit message next time. Thanks!

Default arguments for int.to_bytes(length=1, byteorder=sys.byteorder)

c0c9ca7

the-knights-who-say-ni added the CLA signed label Sep 9, 2021

bedevere-bot added the awaiting core review label Sep 9, 2021

ericvsmith reviewed Sep 9, 2021

View reviewed changes

Update stdlib documentation

5816328

brandtbucher reviewed Sep 9, 2021

View reviewed changes

Comment thread Objects/longobject.c Outdated

JelleZijlstra reviewed Sep 9, 2021

View reviewed changes

Comment thread Doc/library/stdtypes.rst Outdated

warsaw added 3 commits September 9, 2021 16:48

Give int.from_bytes() the same treatment

9b0ec15

Remove some redundancy

97182dc

Fix a related test that uses int.from_bytes()

8bc09d6

Use a faster method to check for endian-ness

cba46c7

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

brandtbucher requested changes Sep 10, 2021

View reviewed changes

Comment thread Objects/longobject.c Outdated

Comment thread Misc/NEWS.d/next/Core and Builtins/2021-09-09-15-05-17.bpo-45155.JRw9TG.rst Outdated

bedevere-bot added awaiting changes and removed awaiting core review labels Sep 10, 2021

warsaw and others added 3 commits September 10, 2021 16:06

Use a faster method to check for endian-ness

712124b

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

Update NEWS entry for this change

8a61d2d

Merge branch 'bchr' of github.com:warsaw/cpython into bchr

a6deed1

bedevere-bot added awaiting change review and removed awaiting changes labels Sep 10, 2021

bedevere-bot requested a review from brandtbucher September 10, 2021 23:12

brandtbucher approved these changes Sep 10, 2021

View reviewed changes

Comment thread Doc/library/stdtypes.rst Outdated

bedevere-bot removed the awaiting change review label Sep 10, 2021

warsaw and others added 2 commits September 13, 2021 09:34

Fix RST typo

c4c82aa

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

Default byteorder to 'big'

354576a

warsaw requested a review from brandtbucher September 15, 2021 04:50

brandtbucher requested changes Sep 15, 2021

View reviewed changes

bedevere-bot added awaiting changes and removed awaiting merge labels Sep 15, 2021

warsaw and others added 5 commits September 15, 2021 09:41

Update Doc/library/stdtypes.rst

a321587

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

Update Doc/library/stdtypes.rst

d468cac

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

Update Doc/library/stdtypes.rst

a6fd648

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

Update Doc/library/stdtypes.rst

7eb77dd

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

Update Misc/NEWS.d/next/Core and Builtins/2021-09-09-15-05-17.bpo-451…

25ec4bb

…55.JRw9TG.rst Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

bedevere-bot added awaiting change review and removed awaiting changes labels Sep 15, 2021

bedevere-bot requested a review from brandtbucher September 15, 2021 16:44

brandtbucher approved these changes Sep 15, 2021

View reviewed changes

Comment thread Objects/longobject.c Outdated

Comment thread Objects/longobject.c Outdated

bedevere-bot added awaiting merge and removed awaiting change review labels Sep 15, 2021

warsaw and others added 2 commits September 15, 2021 13:28

Update Objects/longobject.c

3c34b8c

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

Update Objects/longobject.c

b025642

Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>

Make sure clinic is up to date

a8fcd02

warsaw merged commit 07e737d into python:main Sep 16, 2021

bedevere-bot removed the awaiting merge label Sep 16, 2021

warsaw deleted the bchr branch September 16, 2021 02:55

Uh oh!

Conversation

warsaw commented Sep 9, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhettinger commented Sep 9, 2021

Uh oh!

ericvsmith left a comment

Choose a reason for hiding this comment

Uh oh!

rhettinger commented Sep 9, 2021

Uh oh!

warsaw commented Sep 9, 2021

Uh oh!

rhettinger commented Sep 9, 2021

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

encukou commented Sep 10, 2021

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Sep 10, 2021

Uh oh!

warsaw commented Sep 10, 2021

Uh oh!

bedevere-bot commented Sep 10, 2021

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

warsaw commented Sep 15, 2021

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Sep 15, 2021

Uh oh!

warsaw commented Sep 15, 2021

Uh oh!

warsaw commented Sep 15, 2021

Uh oh!

bedevere-bot commented Sep 15, 2021

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brandtbucher commented Sep 15, 2021

Uh oh!

bedevere-bot commented Sep 16, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

warsaw commented Sep 9, 2021 •

edited by bedevere-bot

Loading